927286 - [keyboard] don't display user's current input as one of the suggestions

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[David Flanagan [:djf]]

Currently for word suggestions and autocorrection, we display two suggestions and the user's current input.  This apparently violates the orignal design, which called for three suggestions and not displaying the user's input.

To switch back to that design, we'll need to add some kind of dismiss button or gesture so that the user can prevent autocorrection of text that is not recognized as a word.

This change also implies that there will not always be a blue highlighted word on the suggestion bar. If the user's input is a correctly spelled word, it will not appear and there won't be an autocorrection, so there will be no blue word. This is a change, but not necessarily a bad one.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

It's a valid and nice improvement, however it does not justify a koi+.

That said, if we have a safe-enough patch I don't see why we cannot land it to v1.2 with an a+.

Comment 2

[Hema Koka [:hema]]

Carrie, I have NI'd you so you can provide the ux recommendation as part of the 1.3 KB work.

Comment 3

[Carrie Wang [New account: [e-mail]]]

Hi, 

I've attached the spec here and also in BOX and Email thread. We've reached the conclusion that the proposal 1 will be adopted for 1.3 and Przmek will provide the icon design. Thanks!

Comment 4

[Carrie Wang [New account: [e-mail]]]

Attachment: [SPEC] dismiss suggesting words.pdf

Comment 5

[Carrie Wang [New account: [e-mail]]]

Attachment: Clear_Icon_Assets.zip

Hey David, 

Przemek has provided a new "x" icon here. 
Please use this one for dismissing suggestion.
Thanks!

Comment 6

[Jan Jongboom [:janjongboom] (inactive)]

Are we sure we have enough screen real estate for this?

Comment 7

[David Flanagan [:djf]]

Attachment: link to patch on github

Rudy or Corey: could one of you review this patch please? This is a feature that must land in 1.3 for legal reasons.

Basically instead of alsways dipslaying the user's input int he suggestion bar, we never display it, and introduce an X icon to dismiss the suggestions.  So if you type "ill" and really want that word instead of "I'll", you'll have to tap the X icon.  Previously you would have typed the "ill" suggestion.

Casey: I've asked you for UI review here since you've been working on the keyboard visual refresh, and because this patch is likely to have merge conflicts with the patch you're working on and I want you to be aware of it.

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8342756 [details] [review]
link to patch on github

Hi David,

Thanks for this work.
r+ with the comments on pull request addressed.

Comment 9

[David Flanagan [:djf]]

Thanks for the very quick review, Rudy!.  I didn't know that about specifying background image size for wvga.

Also, it looks like I need to modify some of Jan's tests for the new autocorrect behavior.

Comment 10

[David Flanagan [:djf]]

I've updated the pull request to address Rudy's comments and fix the failing tests (and add some more tests)

Comment 11

[David Flanagan [:djf]]

Fabrice: I think I need your sheriff's approval to land this feature, please.

Comment 12

[David Flanagan [:djf]]

Attachment: screenshot showing the new button to dismiss suggestions

I'm attaching a screenshot to facilitate UI review

Comment 13

[[:fabrice] Fabrice Desré]

(In reply to David Flanagan [:djf] from comment #11)
> Fabrice: I think I need your sheriff's approval to land this feature, please.

Feel free to land.

Comment 14

[Casey Yee]

David, I will review this with the Carrier today in Taipei.

Comment 15

[Carrie Wang [New account: [e-mail]]]

Hi David, 

We've tried it. I think it works fine. 
Thank!:)

Comment 16

[Casey Yee]

Comment on attachment 8342756 [details] [review]
link to patch on github

We're good to go here.   David, if there is any question about how this fits into the new visual design, please flag me for info.

Comment 17

[David Flanagan [:djf]]

I've got technical review, ux review, green travis build and sheriff approval!

But now there are merge conflicts with the new 1.3 keyboard visuals, so I'll have to update the patch.

Comment 18

[David Flanagan [:djf]]

The merge conflict was easy to resolve.

Landed to master: https://github.com/mozilla-b2g/gaia/commit/1af28d60948bedd277786eadccda1f4c8f637f48